Add deprecation check for tracing.apm.* settings for upgrade assistant #119773
+100
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All usages of tracing.apm.* settings will be presented as a single deprecation issue. Relates to #ES-10293
mosche
added
>non-issue
:Core/Infra/Metrics
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mosche
added a commit
to mosche/elasticsearch
that referenced
this pull request
Jan 9, 2025
elastic#119773) All usages of tracing.apm.* settings will be presented as a single deprecation issue. Relates to #ES-10293 (cherry picked from commit 39c2dd8)
|
Backport is here, missed adding the right label #119850 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All usages of
tracing.apm.*settings will be presented as a single deprecation issue (there could be many of these when configuring the agent), which can possibly be resolved by removing these settings.Though, not sure if this auto-resolution is raising false expectations. Unfortunately we don't have infrastructure for replacing settings in upgrade assistant and - honestly - for this case it doesn't seem worth it building that.
Relates to #ES-10293