WIP: Move LegacyGeoShapeWithDocValuesQueryTests to N-2 compatibility tests #119771
+288
−233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbuescher
added
>non-issue
WIP
:Search/Search
cbuescher
force-pushed
the
LegacyGeoShapeWithDocValuesQueryCompatibilityIT
branch
from
5ea85b8 to
2d23c6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves LegacyGeoShapeWithDocValuesQueryTests to the new
N-2 index version compatibility QA project so we can leverage the test infrastructure
to create indices in v7 and test them after the cluster is upgraded to v8 and v9.
The test in question is currently disabled because v7 indices are not supported in v9.
With this change the two most important test cases are moved to the new full cluster
restart framework, restoring the v7 indices via searchable snapshots in v9. When we also
support reading directly from v7 indices, this can be added easily into this test infrastructure.
Currently this PR is still marked WIP because I only moved to test cases over, but the test inherits many more (~30) via GeoShapeQueryTestCase, so adding all of these would require some additional work.
Maybe we can cherry-pick the most important ones here.