Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Profiling] Remove legacy aggregation_field #119770

Merged

Conversation

rockdaboot
Copy link
Contributor

@rockdaboot rockdaboot commented Jan 8, 2025

Removes support for aggregation_fields, which has been replaced by aggregation_fields.

Reference: elastic/kibana#204024
Pre-requisite: elastic/kibana#205861

@rockdaboot rockdaboot added >tech debt :UniversalProfiling/Application Elastic Universal Profiling REST APIs and infrastructure v9.0.0 labels Jan 8, 2025
@rockdaboot rockdaboot self-assigned this Jan 8, 2025
@elasticsearchmachine elasticsearchmachine added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jan 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@rockdaboot rockdaboot removed the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jan 8, 2025
Copy link

@miloszmarcinkowski miloszmarcinkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not familiar with Java. Now, I see it was pointless to maintain two arguments at the same time. Good it was simplified.

@rockdaboot rockdaboot merged commit b2f290f into elastic:main Jan 9, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team >tech debt :UniversalProfiling/Application Elastic Universal Profiling REST APIs and infrastructure v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants