-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/add custom analyzer old versions #119759
base: main
Are you sure you want to change the base?
Test/add custom analyzer old versions #119759
Conversation
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the clarity of the tests. I think the enum is a bit too much and we should simply use static final strings for the names.
/** | ||
* This is a mapping to the created snapshot zip files, covering test cases for "old repositories" | ||
*/ | ||
public enum Snapshot { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public enum Snapshot { | |
/** | |
* Snapshot zip file names for archive and searchable snapshot tests | |
*/ | |
public final class TestSnapshotCases { | |
//Index created in vES_5 - Basic mapping | |
public static final String ES_VERSION_5 = "5"; | |
// Index created in vES_5 - Custom-Analyzer - standard token filter | |
public static final String ES_VERSION_5_STANDARD_TOKEN_FILTER = "5_custom_analyzer" | |
... | |
} |
Let's make this a simple static class with some static string members. The descriptions are not anything more than what we could provide with a simple java comment.
Create tests to cover
archive-indices
andsearchable-snapshots
created for versionsv5/v6
containing a custom analyzer withstandard-token-filter.
The test case
The code in review #118154, fails to pass the test