[Entitlements] Reintroduce entitlement check on System.exit #119757
Merged
+13
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
:Core/Infra/Core
ldematte
requested review from
prdoyle and
rjernst
and removed request for
prdoyle
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
💚 Backport successful
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during our sync, we should re-introduce the entitlement check on System.exit.
It's not a contract that System.exit calls Runtime.exit; even if unlikely, its implementation could change in a future JDK release, leaving the method unchecked.
In general, now that we have a way to skip the double-check, we should instrument the whole public surface of the JDK (for the methods we need/want to check of course).