Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add semantic_text to data types supported by the match function only if the SEMANTIC_TEXT_TYPE capability is enabled. #119755

Merged
merged 8 commits into from
Jan 8, 2025
Merged

Add semantic_text to data types supported by the match function only if the SEMANTIC_TEXT_TYPE capability is enabled. #119755

merged 8 commits into from
Jan 8, 2025

Conversation

afoucret
Copy link
Contributor

@afoucret afoucret commented Jan 8, 2025 •
edited
Loading

Fix for #119722.

@afoucret
Add semantic_text to data types supported by the match function only …
b347e95 
…if the SEMANTIC_TEXT_TYPE capability is enabled.
@afoucret afoucret added >test-failure Triaged test failures from CI auto-backport Automatically create backport pull requests when merged test-release Trigger CI checks against release build :Analytics/ES|QL AKA ESQL v9.0.0 v8.18.0 labels Jan 8, 2025
@afoucret afoucret requested a review from ioanatia January 8, 2025 13:05
@elasticsearchmachine elasticsearchmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) needs:risk Requires assignment of a risk label (low, medium, blocker) labels Jan 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

carlosdelest
carlosdelest reviewed Jan 8, 2025
View reviewed changes
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, @afoucret !

...ugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/fulltext/Match.java Outdated Show resolved Hide resolved
carlosdelest
carlosdelest approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@afoucret afoucret enabled auto-merge (squash) January 8, 2025 14:59
@afoucret afoucret merged commit cee2360 into elastic:main Jan 8, 2025
17 checks passed
@afoucret afoucret mentioned this pull request Jan 8, 2025
Open
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.x

afoucret added a commit to afoucret/elasticsearch that referenced this pull request Jan 8, 2025
@afoucret
Add semantic_text to data types supported by the match function only …
82f2558 
…if the SEMANTIC_TEXT_TYPE capability is enabled. (elastic#119755)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioanatia ioanatia ioanatia approved these changes

@carlosdelest carlosdelest carlosdelest approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged needs:risk Requires assignment of a risk label (low, medium, blocker) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test-failure Triaged test failures from CI test-release Trigger CI checks against release build v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afoucret @elasticsearchmachine @carlosdelest @ioanatia