Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: connect_transport_exception should be thrown instead of verification_exception when ENRICH-ing if remote is disconnected #119750

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

pawankartik-elastic
Copy link
Contributor

@pawankartik-elastic pawankartik-elastic commented Jan 8, 2025

Before this fix, VerificationException is thrown if a remote is disconnected and skip unavailable is true during ENRICH-ing. This is not what we want. It is expected that a ConnectTransportException be thrown instead. This PR fixes it so that a ConnectTransportException is thrown and additionally adds ENRICH tests for RCS 1 and RCS 2.

…_exception` in ENRICH

In the context of ENRICH, if a remote is disconnected and skip
unavailable is set to `true`, then `verification_exception` is thrown
instead of `connect_transport_exception`. This PR fixes this and adds
the IT tests for ENRICH for RCS 1 and RCS 2.
@pawankartik-elastic pawankartik-elastic added v9.0.0 v8.18.0 :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch labels Jan 8, 2025
@pawankartik-elastic pawankartik-elastic changed the title fix: verification_exception is thrown instead of connect_transport_exception in ENRICH when remote is disconnected fix: connect_transport_exception should be thrown instead of verification_exception when ENRICH-ing if remote is disconnected Jan 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @pawankartik-elastic, I've created a changelog YAML for you.

@pawankartik-elastic pawankartik-elastic marked this pull request as ready for review January 8, 2025 15:03
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@pawankartik-elastic pawankartik-elastic added the auto-backport Automatically create backport pull requests when merged label Jan 8, 2025
@quux00 quux00 added v8.17.2 and removed v8.17.0 labels Jan 8, 2025
@quux00 quux00 changed the title fix: connect_transport_exception should be thrown instead of verification_exception when ENRICH-ing if remote is disconnected ESQL: connect_transport_exception should be thrown instead of verification_exception when ENRICH-ing if remote is disconnected Jan 8, 2025
Copy link
Contributor

@quux00 quux00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note : I adjusted the title and the changelog to start with "ESQL", as that's the format ESQL wants for the release notes. I also adjusted the v8.17.0 label v8.17.2, as you want to target the next release in the autobackport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged >bug :Search Foundations/Search Catch all for Search Foundations Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.17.2 v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants