use Monolog's FormatterInterface format method original signature #75
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the original Monolog's
FormatterInterface
format
method signature does not impose any return type while theElasticCommonSchemaFormatter
does impose a return type ofstring
:ecs-logging-php/src/Elastic/Monolog/Formatter/ElasticCommonSchemaFormatter.php
Line 83 in 978b848
this change removes this limitation so it's possible to override the
format
method and return a different type(ex: array).the usecase i have here is that i want to combine the
ElasticCommonSchemaFormatter
with a monolog handler that uses the fluent logger to send logs to fluent-bit, fluent-bit's forward protocol accept only messages inmsgpack
format, so messages are packed using msgpack php extension, since the message are encoded in a format other then JSON, there is no need here to encode theecs
message to json(currently it's automatically done in theformat
method)ecs-logging-php/src/Elastic/Monolog/Formatter/ElasticCommonSchemaFormatter.php
Line 132 in 978b848
and then later decode it, instead i would need only the formatted array so it can be further packed into a
msgpack
to be sent to fluent-bit.