Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metricbeat: Update beat module with apm-server tail sampling monitoring metrics fields #42569

Merged
merged 4 commits into from
Feb 3, 2025
Merged

metricbeat: Update beat module with apm-server tail sampling monitoring metrics fields #42569

merged 4 commits into from
Feb 3, 2025
+293 −56

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Feb 3, 2025 •
edited
Loading

Proposed commit message

Update metricbeat beat module mapping to add back missing apm-server tail sampling montioring metrics fields.

The fields were missed in #40127

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

  • Start apm-server with monitoring
  • Start standalone metricbeat with beat module
  • Confirm that fields are mapped correctly in metricbeat-* data stream

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 3, 2025
@botelastic
Copy link

botelastic bot commented Feb 3, 2025

This pull request doesn't have a Team:<team> label.

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 3, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @carsonip? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@carsonip carsonip added backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify backport-9.0 Automated backport to the 9.0 branch bug labels Feb 3, 2025
@carsonip carsonip requested a review from klacabane February 3, 2025 16:13
@carsonip carsonip marked this pull request as ready for review February 3, 2025 16:13
@carsonip carsonip requested a review from a team as a code owner February 3, 2025 16:14
@carsonip carsonip mentioned this pull request Feb 3, 2025
Open
@carsonip carsonip added the backport-8.18 Automated backport to the 8.18 branch label Feb 3, 2025
pickypg
pickypg approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@pickypg pickypg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carsonip carsonip merged commit 9134522 into elastic:main Feb 3, 2025
32 checks passed
mergify bot pushed a commit that referenced this pull request Feb 3, 2025
@carsonip @mergify
metricbeat: Update beat module with apm-server tail sampling monitori…
22868e4 
…ng metrics fields (#42569)

Update metricbeat beat module mapping to add back missing apm-server tail sampling montioring metrics fields.

The fields were missed in #40127

(cherry picked from commit 9134522)

# Conflicts:
#	metricbeat/module/beat/fields.go
mergify bot pushed a commit that referenced this pull request Feb 3, 2025
@carsonip @mergify
metricbeat: Update beat module with apm-server tail sampling monitori…
98cbba2 
…ng metrics fields (#42569)

Update metricbeat beat module mapping to add back missing apm-server tail sampling montioring metrics fields.

The fields were missed in #40127

(cherry picked from commit 9134522)
mergify bot pushed a commit that referenced this pull request Feb 3, 2025
@carsonip @mergify
metricbeat: Update beat module with apm-server tail sampling monitori…
efb4fe1 
…ng metrics fields (#42569)

Update metricbeat beat module mapping to add back missing apm-server tail sampling montioring metrics fields.

The fields were missed in #40127

(cherry picked from commit 9134522)
This was referenced Feb 3, 2025
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request Feb 3, 2025
@carsonip @mergify
metricbeat: Update beat module with apm-server tail sampling monitori…
d46cd4d 
…ng metrics fields (#42569)

Update metricbeat beat module mapping to add back missing apm-server tail sampling montioring metrics fields.

The fields were missed in #40127

(cherry picked from commit 9134522)
@mergify mergify bot mentioned this pull request Feb 3, 2025
Merged
6 tasks
mergify bot pushed a commit that referenced this pull request Feb 3, 2025
@carsonip @mergify
metricbeat: Update beat module with apm-server tail sampling monitori…
3e99b54 
…ng metrics fields (#42569)

Update metricbeat beat module mapping to add back missing apm-server tail sampling montioring metrics fields.

The fields were missed in #40127

(cherry picked from commit 9134522)

# Conflicts:
#	metricbeat/module/beat/fields.go
@mergify mergify bot mentioned this pull request Feb 3, 2025
Open
6 tasks
carsonip added a commit that referenced this pull request Feb 3, 2025
@mergify @carsonip
metricbeat: Update beat module with apm-server tail sampling monitori…
31a1552 
…ng metrics fields (#42569) (#42574)

Update metricbeat beat module mapping to add back missing apm-server tail sampling montioring metrics fields.

The fields were missed in #40127

(cherry picked from commit 9134522)

Co-authored-by: Carson Ip <[email protected]>
carsonip added a commit that referenced this pull request Feb 3, 2025
@mergify @carsonip
[8.16](backport #42569) metricbeat: Update beat module with apm-serve…
48f2ed7 
…r tail sampling monitoring metrics fields (#42573)

* metricbeat: Update beat module with apm-server tail sampling monitoring metrics fields (#42569)

Update metricbeat beat module mapping to add back missing apm-server tail sampling montioring metrics fields.

The fields were missed in #40127

(cherry picked from commit 9134522)

# Conflicts:
#	metricbeat/module/beat/fields.go

* Fix conflicts

---------

Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: Carson Ip <[email protected]>
carsonip added a commit that referenced this pull request Feb 3, 2025
@mergify @carsonip
[8.17](backport #42569) metricbeat: Update beat module with apm-serve…
7b9feb2 
…r tail sampling monitoring metrics fields (#42575)

* metricbeat: Update beat module with apm-server tail sampling monitoring metrics fields (#42569)

Update metricbeat beat module mapping to add back missing apm-server tail sampling montioring metrics fields.

The fields were missed in #40127

(cherry picked from commit 9134522)

* Fix backport merge

---------

Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: Carson Ip <[email protected]>
carsonip added a commit that referenced this pull request Feb 3, 2025
@mergify @carsonip
[8.18](backport #42569) metricbeat: Update beat module with apm-serve…
47d83f1 
…r tail sampling monitoring metrics fields (#42576)

* metricbeat: Update beat module with apm-server tail sampling monitoring metrics fields (#42569)

Update metricbeat beat module mapping to add back missing apm-server tail sampling montioring metrics fields.

The fields were missed in #40127

(cherry picked from commit 9134522)

* Fix backport merge

---------

Co-authored-by: Carson Ip <[email protected]>
Co-authored-by: Carson Ip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pickypg pickypg pickypg approved these changes

@klacabane klacabane Awaiting requested review from klacabane

Assignees

@carsonip carsonip

Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch bug needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carsonip @pickypg