feat: start hiding beats monitoring behind otel abstraction #15360
+457
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
|
|
|
mergify
bot
added
the
backport-8.x
2 tasks
axw
reviewed
Jan 24, 2025
- Only adapt go-docappender metrics when using the Elasticsearch output - Increment processed events properly. - Create object hierarchy rather than dotted metric names so _source remains backwards compatible. Revert system test changes. - Report elasticsearch.indexers.active; use correct names for go-docappender indexer creation/destruction OTel metrics. ... and add a unit test for all of that
axw
previously approved these changes
Jan 24, 2025
simitt
approved these changes
Jan 24, 2025
| for _, dp := range data.DataPoints { | ||
| status, ok := dp.Attributes.Value(attribute.Key("status")) | ||
| if !ok { | ||
| continue |
There was a problem hiding this comment.
Should we log a warning here? Afaics this wouldn't be expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
Split from #15094
part 1
Checklist
For functional changes, consider:
How to test these changes
Related issues