Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script][combat-trainer] Updates for focus_threshold #7076

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

mdr55
Copy link
Contributor

@mdr55 mdr55 commented Jan 27, 2025

updates

  1. The hard minimum for focus_threshold may be too conservative. A value of ~4 may be workable for a weapon tert. For other skillset placements focus_threshold may need to be higher to account for drain whilst stuck on a weapon going for 34/34 (so you don't end up with 0 ms on a skill with no ability to correct until the 34 is done). Setting the minimum to say > 1 gives the player freedom to set what is needed for their char and specific circumstances.
  2. Conditional CT break bug fix (if focus_threshold was activated + the bottom of the hysterisis band was reached). Rookie mistake :(

@mdr55 mdr55 marked this pull request as ready for review January 27, 2025 21:44
@mdr55
Copy link
Contributor Author

mdr55 commented Jan 27, 2025

ready for review. #2 is conditionally breaking for users of feature

@mdr55 mdr55 changed the title [script][combat-trainer] Tuning updates for focus_threshold [script][combat-trainer] Updates for focus_threshold Jan 27, 2025
@MahtraDR MahtraDR merged commit 4b0dd06 into elanthia-online:main Jan 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants