[script][combat-trainer] YACTOM: "offhand_trainables" #7073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahtraDR
requested changes
Jan 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optional - and its kind of advance-ish - feature is turned on by combat_trainer_offhand_trainables: true in yaml.
It will intentionally preference loadable weapons (bow, xbow, sling) first, all weapons which are NOT aiming_trainables second, and aiming_trainables last. This indirectly forces skills tagged for aiming_trainables to be used in the offhand, and not take up valuable time being wielded in the mainhand and competing for timeslots with other mainhand/twohand only weapons.
It has a functional dependency on focus_threshold feature in PR #7071, requiring focus to be active. This means that the preferencing will NOT start until all mindstates have achieved some minimum value, to ensure all weapons are draining.