[script][combat-trainer] QOL improvement to use of collect #7056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahtraDR
reviewed
Jan 15, 2025
combat-trainer.lic
Outdated
Comment on lines
2958
to
2966
| if !game_state.loaded then | ||
| game_state.sheath_whirlwind_offhand | ||
| DRC.retreat | ||
| game_state.engage unless game_state.npcs.empty? || game_state.retreating? | ||
| DRC.collect(@forage_item) | ||
| waitrt? | ||
| game_state.wield_whirlwind_offhand | ||
| DRC.kick_pile? | ||
| end |
There was a problem hiding this comment.
Suggested change
| if !game_state.loaded then | |
| game_state.sheath_whirlwind_offhand | |
| DRC.retreat | |
| game_state.engage unless game_state.npcs.empty? || game_state.retreating? | |
| DRC.collect(@forage_item) | |
| waitrt? | |
| game_state.wield_whirlwind_offhand | |
| DRC.kick_pile? | |
| end | |
| return unless game_state.loaded | |
| game_state.sheath_whirlwind_offhand | |
| DRC.retreat | |
| game_state.engage unless game_state.npcs.empty? || game_state.retreating? | |
| DRC.collect(@forage_item) | |
| waitrt? | |
| game_state.wield_whirlwind_offhand | |
| DRC.kick_pile? |
There was a problem hiding this comment.
Uh, with the correct indentation, of course...
There was a problem hiding this comment.
Updated, looks much cleaner now
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mask the use of collect if we have a loaded weapon. Its likely that the RT from collect will result in the weapon switch window being exceeded and wasting the load & aim time already invested. Given collect is less time critical and not directly combat related, suggest its ok to drop it in preference to losing an aim slot.