Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[scripts][combat-trainer] Use Firebase to store warhorn/egg data (2 of 2) #6673

Closed
wants to merge 30 commits into from

Conversation

MahtraDR
Copy link
Collaborator

Depends on #6672

Checks if a room has a warhorn/egg timer before using our warhorn or egg.

Allows multiple people to consecutively (or at least not in an overlapping manner) use their eggs/warhorns in the same room.

@MahtraDR MahtraDR changed the title [scripts][combat-trainer] Use Firebase to store warhorn/egg data [scripts][combat-trainer] Use Firebase to store warhorn/egg data (1 of 2) Aug 23, 2023
@MahtraDR MahtraDR changed the title [scripts][combat-trainer] Use Firebase to store warhorn/egg data (1 of 2) [scripts][combat-trainer] Use Firebase to store warhorn/egg data (2 of 2) Aug 23, 2023
@vtcifer
Copy link
Contributor

vtcifer commented Aug 29, 2023

I don't see game instance data included in this or the other PR. Am I missing it or is it possible we'd get polluted data from DRF/DRX. And vice versa.

@MahtraDR
Copy link
Collaborator Author

I don't see game instance data included in this or the other PR. Am I missing it or is it possible we'd get polluted data from DRF/DRX. And vice versa.

Excellent point. Thank you. I can add a game instance check.

@MahtraDR
Copy link
Collaborator Author

MahtraDR commented Sep 1, 2023

I'm leaving this one to stew, because even with just the PR as is, with the limited testing it's getting, it's using up near enough data in our free Firebase plan to cause me to get a bill. Even if it's just a few dollars a month, I can't justify paying for this... I might well keep it as a private edit, but leaving it to stew longer.

@MahtraDR MahtraDR closed this Jun 8, 2024
@MahtraDR MahtraDR deleted the ct_use_hornwatch branch June 8, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants