Improve installation of certificate #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmirnow
force-pushed
the
improve-cert-installation
branch
from
fb6dffc to
61c9791
Compare
|
The linting errors are fixed by #6 |
lkiesow
approved these changes
Jan 19, 2025
Comment on lines
+59
to
+62
| - name: Reload nginx | ||
| ansible.builtin.systemd: | ||
| name: nginx | ||
| state: reloaded |
There was a problem hiding this comment.
Not necessarily something to change, just a question for my understanding:
Is this to ensure we already have valid certificates loaded for later roles?
Because otherwise, we could work with a notify:.
There was a problem hiding this comment.
Yes it is. The nginx reload will be run always. This is ok, because we do not change nginx configuration but only replace the certificate. We assume the nginx config is valid as the daemon is running. Otherwise the ACME webroot challenge will not succeed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task make no sense without nginx. But the ssl directory may not exist. This role should not fail in this case.