Skip to content

Commit

Permalink
address rubocop issues
Browse files Browse the repository at this point in the history
  • Loading branch information
eheydrick committed Dec 28, 2016
1 parent 07aa861 commit ebf251c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 3 deletions.
10 changes: 9 additions & 1 deletion .rubocop.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Rubocop, we're buddies and all, but we're going to have to disagree on the following -
# Rubocop, we're buddies and all, but we're going to have to disagree on the following -

# Allow compact class definitions
Style/ClassAndModuleChildren:
Expand Down Expand Up @@ -97,3 +97,11 @@ Style/SpaceBeforeFirstArg:
AllCops:
Include:
- '**/*.rb'

# allow longer blocks
Metrics/BlockLength:
Max: 50

# allow longer argument lists
Metrics/ParameterLists:
Max: 6
2 changes: 1 addition & 1 deletion bin/aws_cleaner.rb
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ def config(file)
if @instance_id
if @config[:webhooks]
@config[:webhooks].each do |hook, hook_config|
if AwsCleaner::Webhooks::fire_webhook(hook_config, @config, @instance_id)
if AwsCleaner::Webhooks.fire_webhook(hook_config, @config, @instance_id)
puts "Successfully ran webhook #{hook}"
else
puts "Failed to run webhook #{hook}"
Expand Down
2 changes: 1 addition & 1 deletion lib/aws_cleaner/aws_cleaner.rb
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def self.notify_chat(msg, config)

module Webhooks
# generate the URL for the webhook
def self.generate_template(item, template_variable_method, template_variable_argument, template_variable, config, instance_id)
def self.generate_template(item, template_variable_method, _template_variable_argument, template_variable, config, instance_id)
if template_variable_method == 'get_chef_fqdn'
replacement = AwsCleaner::Chef.get_chef_fqdn(instance_id, config)
elsif template_variable_method == 'get_chef_node_name'
Expand Down

0 comments on commit ebf251c

Please sign in to comment.