Subsume should succeed even when the tuple is not present in the database #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihozhang
commented
Dec 5, 2024
| @@ -124,13 +124,6 @@ impl Table { | |||
| Some(&self.vals[off].1) | |||
| } | |||
|
|
|||
| pub(crate) fn get_mut(&mut self, inputs: &[Value]) -> Option<&mut TupleOutput> { | |||
There was a problem hiding this comment.
get_mut() is unsafe because it does not require the caller to update the timestamp. Use insert_and_merge instead.
CodSpeed Performance ReportMerging #478 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #462