Fix telnet mode / esc codes for stdout #1784
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found by: michaelortmann
Patch by: michaelortmann
Fixes:
One-line summary:
Fix telnet mode / esc codes for stdout
Additional description (if needed):
Enable telnet mode / do not strip esc codes if stdout is a tty
Dont you worry, even your moms vt100 from 1978 supports the esc codes / telnet codes we use.
This issue is user facing. It has been bothering me for a long time.
Test cases demonstrating functionality (if applicable):
left side: before, right side: after
https://imgur.com/a/N24vu08
in other words:
Start the bot into dcc chat simulation (HQ), like:
./eggdrop -t bot.confBefore:
HQs telnet mode will be off. so for example HQ via tty will not see bold text in motd.
After:
if eggdrop detects stdout is a tty, it will enable telnet mode. so HQ will see bold text in motd.