Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sleep less #1777

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

michaelortmann
Copy link
Member

@michaelortmann michaelortmann commented Feb 12, 2025

Found by: michaelortmann
Patch by: michaelortmann
Fixes:

One-line summary:
Sleep less - improve responsiveness user experience

Additional description (if needed):
Lower amount of time we sleep() in some exit/quit situations.
I would favor to remove all such sleeps ;)
But because of historical reasons, lets just lower the amount here.
I checked ircii, irssi and weechat and there is no single sleep in them longer than 2 secs.
mirc removed any sleep a long time ago: https://forums.mirc.com/ubbthreads.php/topics/251851/exit-and-quit-message
Also i argue: why do we sleep in some situations, when in others we dont need to, like .jump does not sleep:

.jump 127.0.0.1
18:04:33.309994 write(8, "QUIT :changing servers\n", 23) = 23
18:04:33.310534 close(8)                = 0

Test cases demonstrating functionality (if applicable):
2 sleeps were modified, so i checked both situations:

  1. /msg <bot> die <passwd>
  2. kill <pid_of_bot>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant