Skip to content

Commit

Permalink
Fixes #33 UI strings read 'Github' instead of 'GitHub'
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarjs committed Jun 12, 2021
1 parent 6cd3924 commit 69d8b51
Show file tree
Hide file tree
Showing 7 changed files with 13 additions and 13 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ This project is published under the [MIT License](LICENSE.md).
[github-search]: https://docs.github.com/en/free-pro-team@latest/github/searching-for-information-on-github/searching-on-github
[download-packal]: https://www.packal.org/workflow/github-repos
[download-releases]: https://github.com/edgarjs/alfred-github-repos/releases
[personal-access-token]: https://github.com/settings/tokens/new?description=Github%20Repos%20Alfred%20workflow&scopes=repo
[personal-access-token]: https://github.com/settings/tokens/new?description=GitHub%20Repos%20Alfred%20workflow&scopes=repo
[pulls-page]: https://github.com/pulls
[notifications-page]: https://github.com/notifications
[alfred-env-vars]: https://www.alfredapp.com/help/workflows/script-environment-variables/
4 changes: 2 additions & 2 deletions app.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
$stdout.sync = true
$LOAD_PATH.unshift File.expand_path('lib')

require 'data_source/client/github'
require 'data_source/client/git_hub'
require 'data_source/pull_requests'
require 'data_source/repositories'
require 'commands/help'
Expand All @@ -14,7 +14,7 @@
class App
class << self
def client
DataSource::Client::Github.new(
DataSource::Client::GitHub.new(
host: ENV['GITHUB_API_HOST'],
access_token: ENV['GITHUB_ACCESS_TOKEN'],
me_account: ENV['GITHUB_ME_ACCOUNT'],
Expand Down
4 changes: 2 additions & 2 deletions assets/info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ fi</string>
<key>spaces</key>
<string></string>
<key>url</key>
<string>https://{var:GITHUB_HOST}/settings/tokens/new?description=Github%20Repos%20Alfred%20workflow&amp;scopes=repo</string>
<string>https://{var:GITHUB_HOST}/settings/tokens/new?description=GitHub%20Repos%20Alfred%20workflow&amp;scopes=repo</string>
<key>utf8</key>
<false/>
</dict>
Expand Down Expand Up @@ -448,7 +448,7 @@ fi</string>
<key>spaces</key>
<string></string>
<key>url</key>
<string>https://{var:GITHUB_HOST}/settings/tokens/new?description=Github%20Repos%20Alfred%20workflow&amp;scopes=repo</string>
<string>https://{var:GITHUB_HOST}/settings/tokens/new?description=GitHub%20Repos%20Alfred%20workflow&amp;scopes=repo</string>
<key>utf8</key>
<false/>
</dict>
Expand Down
2 changes: 1 addition & 1 deletion lib/commands/help.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module Commands
class Help

HEAD = <<~HEAD
Github Repos workflow for Alfred - CLI
GitHub Repos workflow for Alfred - CLI
Version: #{App::VERSION}
HEAD

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

module DataSource
module Client
class Github
class GitHub

def initialize(config)
@config = {
Expand Down
2 changes: 1 addition & 1 deletion test/lib/commands/help_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
module Commands
class HelpTest < Minitest::Test
HEAD = <<~HEAD
Github Repos workflow for Alfred - CLI
GitHub Repos workflow for Alfred - CLI
Version: #{App::VERSION}
HEAD

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@

require 'test_helper'
require 'fileutils'
require 'data_source/client/github'
require 'data_source/client/git_hub'

module DataSource
module Client
class GithubTest < Minitest::Test
class GitHubTest < Minitest::Test
def setup
super
FileUtils.mkdir_p('tmp/cache')
Expand All @@ -16,7 +16,7 @@ def setup
end

def subject
@subject ||= Github.new(host: 'example.com', access_token: 'test_token',
@subject ||= GitHub.new(host: 'example.com', access_token: 'test_token',
me_account: "@me", pr_all_involve_me: false)
end

Expand All @@ -33,7 +33,7 @@ def cache_ttl_sec_pr
end

def subject_with_cache
@subject_with_cache ||= Github.new(
@subject_with_cache ||= GitHub.new(
host: 'example.com',
access_token: 'test_token',
cache_dir: 'tmp/cache',
Expand All @@ -46,7 +46,7 @@ def subject_with_cache
end

def subject_with_pr_all_involve_me_true
@subject_with_cache ||= Github.new(
@subject_with_cache ||= GitHub.new(
host: 'example.com',
access_token: 'test_token',
me_account: "@me",
Expand Down

0 comments on commit 69d8b51

Please sign in to comment.