Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-1287: Add CI job for E2E tests #229

Merged
merged 1 commit into from
Jul 23, 2024
Merged

GLSP-1287: Add CI job for E2E tests #229

merged 1 commit into from
Jul 23, 2024

Conversation

tortmayr
Copy link
Contributor

What it does

Add CI job for E2E tests
And general cleanup/improvements of other workflows

How to test

The E2E CI job should run and succeed for the PR.

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

@tortmayr tortmayr force-pushed the glsp-1287-e2e branch 3 times, most recently from 519260d to 90c4b47 Compare July 23, 2024 13:56
And general cleanup/improvements of other workflows
Copy link

@haydar-metin haydar-metin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eclipse-glsp/glsp#1287 (comment)

Currently we are using env variables that are not necessary for that integration, but without them, warnings are shown in the logs. I will fix them in a different PR. Your changes LGTM 👍

@tortmayr tortmayr merged commit 2389639 into master Jul 23, 2024
4 checks passed
@tortmayr tortmayr deleted the glsp-1287-e2e branch July 23, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants