Introduce core functionality tests #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 5, 2024
haydar-metin
force-pushed
the
issues/1287_core
branch
2 times, most recently
from
4c6db97 to
12b41f8
Compare
haydar-metin
force-pushed
the
issues/1287_core
branch
from
12b41f8 to
763ff15
Compare
|
@tortmayr FYI: the tests are now green 🟢 |
tortmayr
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Code and test looks good to me.
There is a minor linting warning due to duplicated imports: https://github.com/eclipse-glsp/glsp-playwright/actions/runs/10903764106/attempts/1#summary-30258583887
Other than that LGTM!
haydar-metin
force-pushed
the
issues/1287_core
branch
from
763ff15 to
b09f87c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Introduces / improves / checks existing test cases for
New Assertions:
toContainClass- Checks if the element has the css classtoContainElement- Checks if the graph contains the elementtoBeSelected- Checks that the element is selectedHow to test
yarnyarn testFollow-ups
VSCode Skipped Tests:
eclipse-glsp/glsp#1402
Changelog
This PR should be mentioned in the changelog
This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)
PMetadata.assertOwnhas been renamed toPMetadata.assert.