Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add host and port configuration #409

Conversation

holkerveen
Copy link
Contributor

@holkerveen holkerveen commented Dec 21, 2024

What it does

This PR is for including host and port configuration to the example/standalone server start script, as well as to the standalone frontend app. Defaults are specified such that original operation should be unchanged.

I opted to parse the relevant command line arguments myself as opposed to with a library, because I felt it is a bit of overkill to introduce an extra dependency for parsing command line arguments.

closes eclipse-glsp/glsp#1410

How to test

From the examples/workflow-standalone dir, start the example server with something like yarn ts-node scripts/start-example-server.ts --port 1234 --host 127.0.0.1 or similar, and build the frontend app with GLSP_SERVER_PORT=1234 GLSP_SERVER_HOST=127.0.0.1 yarn build.

The server should listen on the port and host specified, and the frontend should attempt to connect to the same.
Observe that default configuration has not changed

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

@holkerveen
Copy link
Contributor Author

Hi there! I did complete the ECA and could validate by entering my username in the ECA Validation Tool. I don't know how to re-check though

@tortmayr tortmayr self-requested a review December 23, 2024 09:40
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍🏼

I retriggered the ECA check and now everything passes.

@tortmayr tortmayr merged commit f30c550 into eclipse-glsp:master Dec 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get standalone working in a docker environment
2 participants