Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR is for including host and port configuration to the example/standalone server start script, as well as to the standalone frontend app. Defaults are specified such that original operation should be unchanged.
I opted to parse the relevant command line arguments myself as opposed to with a library, because I felt it is a bit of overkill to introduce an extra dependency for parsing command line arguments.
closes eclipse-glsp/glsp#1410
How to test
From the
examples/workflow-standalone
dir, start the example server with something likeyarn ts-node scripts/start-example-server.ts --port 1234 --host 127.0.0.1
or similar, and build the frontend app withGLSP_SERVER_PORT=1234 GLSP_SERVER_HOST=127.0.0.1 yarn build
.The server should listen on the port and host specified, and the frontend should attempt to connect to the same.
Observe that default configuration has not changed
Follow-ups
Changelog