Various minor improvements #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-fleck-at
requested changes
Nov 25, 2024
| @@ -29,7 +30,7 @@ export interface FocusChange { | |||
| * Allows querying of the current focus state and the focused root diagram element and the currently focused element within the diagram. | |||
| */ | |||
| @injectable() | |||
| export class FocusTracker implements IActionHandler { | |||
| export class FocusTracker implements IActionHandler, IDiagramStartup { | |||
| protected inActiveCssClass = 'inactive'; | |||
| protected _hasFocus = true; | |||
There was a problem hiding this comment.
I wonder if that should really be true now that we actually track the focus change in the beginning?
| postModelInitialization(): MaybePromise<void> { | ||
| this.handleFocusChange(); | ||
| } | ||
|
|
||
| handle(action: Action): void | Action | ICommand { | ||
| if (!FocusStateChangedAction.is(action)) { | ||
| return; | ||
| } | ||
|
|
||
| this._hasFocus = action.hasFocus; |
There was a problem hiding this comment.
This should probably be initialized correctly somehow.
- Merge *-default.ts implementation files of `FeedbackActionDispatcher` and `HelperLineManager` with the the interface definition files. The split is no longer necessary since we resolved potential circular dependency issues - Ensure that we consistently use the `LazyInjector` over dedicated async providers and deprecate existing provider injection - Move MaybeActions utility type from feedback-action-dispatcher into the protocol package to enable reuse + add testcases
tortmayr
force-pushed
the
tortmayr/fixes
branch
from
9b9fc1b to
483a189
Compare
|
Thanks for the review Martin. I decided to revert the focus tracker fix for now. |
martin-fleck-at
approved these changes
Dec 6, 2024
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
+Fix eclipse-glsp#401 Node creation (eclipse-glsp#402) + Resolve eclipse-glsp#398 Refactor TypeHints API (eclipse-glsp#399) + Resolve eclipse-glsp#396 RouterKind for FeedbackEdge (eclipse-glsp#397) + Reuse Sprotty's request/response system and remove custom solution(eclipse-glsp#404) + Add support for context menu and harmonize with command palette (eclipse-glsp#405)
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
+Fix eclipse-glsp#401 Node creation (eclipse-glsp#402) + Resolve eclipse-glsp#398 Refactor TypeHints API (eclipse-glsp#399) + Resolve eclipse-glsp#396 RouterKind for FeedbackEdge (eclipse-glsp#397) + Reuse Sprotty's request/response system and remove custom solution(eclipse-glsp#404) + Add support for context menu and harmonize with command palette (eclipse-glsp#405)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
FeedbackActionDispatcherandHelperLineManagerwith the the interface definition files. The split is no longer necessary since we resolved potential circular dependency issuesLazyInjectorover dedicated async providers and deprecate existing provider injectionHow to test
Follow-ups
Changelog