Improve ToolManagerAPI #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add `defaultToolsEnabled` flag to `ToolManager` which is true if currently only the default tools are enabled i.e. no tools have been enabled explicitly - Avoid (re)activation of default tools if the are already enabled - Remove unused GRID_STYLE property
martin-fleck-at
approved these changes
Jun 25, 2024
Co-authored-by: Martin Fleck <[email protected]>
Co-authored-by: Martin Fleck <[email protected]>
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
- Add `defaultToolsEnabled` flag to `ToolManager` which is true if currently only the default tools are enabled i.e. no tools have been enabled explicitly - Avoid (re)activation of default tools if the are already enabled - Remove unused GRID_STYLE property Co-authored-by: Martin Fleck <[email protected]>
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
- Add `defaultToolsEnabled` flag to `ToolManager` which is true if currently only the default tools are enabled i.e. no tools have been enabled explicitly - Avoid (re)activation of default tools if the are already enabled - Remove unused GRID_STYLE property Co-authored-by: Martin Fleck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
defaultToolsEnabledflag toToolManagerwhich is true if currently only the default tools are enabled i.e. no tools have been enabled explicitlyHow to test
Follow-ups
Changelog