Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with change bounds tool #361

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

tortmayr
Copy link
Contributor

What it does

  • Ensure that the change bounds tool does not dispatch ChangeRoutingPointsAction if there are not valid element moves.
  • Ensure that duplicate detection in resolveContainerConfiguration properly stringifies symboles.

How to test

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

- Ensure that the change bounds tool does not dispatch `ChangeRoutingPointsAction` if there are not valid element moves.
- Ensure that duplicate detection in `resolveContainerConfiguration` properly stringifies symboles.
@tortmayr tortmayr requested a review from martin-fleck-at June 17, 2024 12:08
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martin-fleck-at martin-fleck-at merged commit 663c6df into master Jun 17, 2024
6 checks passed
@tortmayr tortmayr deleted the fix-change-bounds branch June 17, 2024 12:59
holkerveen pushed a commit to holkerveen/glsp-client that referenced this pull request Dec 21, 2024
- Ensure that the change bounds tool does not dispatch `ChangeRoutingPointsAction` if there are not valid element moves.
- Ensure that duplicate detection in `resolveContainerConfiguration` properly stringifies symboles.
holkerveen pushed a commit to holkerveen/glsp-client that referenced this pull request Dec 21, 2024
- Ensure that the change bounds tool does not dispatch `ChangeRoutingPointsAction` if there are not valid element moves.
- Ensure that duplicate detection in `resolveContainerConfiguration` properly stringifies symboles.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants