Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with UI extensions #360

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Fix issue with UI extensions #360

merged 1 commit into from
Jun 17, 2024

Conversation

martin-fleck-at
Copy link
Contributor

What it does

  • Use our GLSPAbstractUIExtension instead of AbstractUIExtension
  • Fix focus issue with GlspEditLabelUI

How to test

  • Ensure that whenever you show the label edit UI, the text field gets proper focus
  • Test other UI extensions behave as before

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

@martin-fleck-at
Fix issue with UI extensions
c48bbc4 
- Use our GLSPAbstractUIExtension instead of AbstractUIExtension
- Fix focus issue with GlspEditLabelUI
@martin-fleck-at martin-fleck-at requested a review from tortmayr June 17, 2024 08:33
tortmayr
tortmayr approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@martin-fleck-at martin-fleck-at merged commit 062e335 into master Jun 17, 2024
6 checks passed
@martin-fleck-at martin-fleck-at deleted the fix-ui-extensions branch June 17, 2024 08:45
holkerveen pushed a commit to holkerveen/glsp-client that referenced this pull request Dec 21, 2024
@martin-fleck-at @holkerveen
Fix issue with UI extensions (eclipse-glsp#360)
b2faeeb 
- Use our GLSPAbstractUIExtension instead of AbstractUIExtension
- Fix focus issue with GlspEditLabelUI
holkerveen pushed a commit to holkerveen/glsp-client that referenced this pull request Dec 21, 2024
@martin-fleck-at @holkerveen
Fix issue with UI extensions (eclipse-glsp#360)
e9c6636 
- Use our GLSPAbstractUIExtension instead of AbstractUIExtension
- Fix focus issue with GlspEditLabelUI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortmayr tortmayr tortmayr approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-fleck-at @tortmayr