Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Grid functionality and customizability #359

Merged
merged 2 commits into from
Jun 15, 2024
Merged

Conversation

martin-fleck-at
Copy link
Contributor

What it does

  • Ensure grid is applied on normal graph view without projections
  • Allow grid color to be specified through CSS
  • Add more properties to the graph for re-use

How to test

  • Test graph view and graph projection view and try to change the grid color through CSS

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

- Ensure grid is applied on normal graph view without projections
- Allow grid color to be specified through CSS
- Add more properties to the graph for re-use
@martin-fleck-at martin-fleck-at requested a review from tortmayr June 14, 2024 09:38
Color definitions with a # need to be escaped to be properly rendered
when used in a background image url
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tortmayr tortmayr merged commit d49f704 into master Jun 15, 2024
6 checks passed
@tortmayr tortmayr deleted the enhance-grid branch June 15, 2024 15:04
holkerveen pushed a commit to holkerveen/glsp-client that referenced this pull request Dec 21, 2024
* Enhance Grid functionality and customizability

- Ensure grid is applied on normal graph view without projections
- Allow grid color to be specified through CSS
- Add more properties to the graph for re-use

* Properly escape grid color values

Color definitions with a # need to be escaped to be properly rendered
when used in a background image url
holkerveen pushed a commit to holkerveen/glsp-client that referenced this pull request Dec 21, 2024
* Enhance Grid functionality and customizability

- Ensure grid is applied on normal graph view without projections
- Allow grid color to be specified through CSS
- Add more properties to the graph for re-use

* Properly escape grid color values

Color definitions with a # need to be escaped to be properly rendered
when used in a background image url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants