Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional actions to avoid console errors #310

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

martin-fleck-at
Copy link
Contributor

See eclipse-glsp/glsp#1203

You can test it by removing the helperLineModule from the workflow-diagram-module.ts to see how it behaves before and after.

Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Code looks good to me and seems to work as expected.

@martin-fleck-at martin-fleck-at merged commit 159e69f into master Jan 19, 2024
6 checks passed
@martin-fleck-at martin-fleck-at deleted the issues/optional-actions branch January 19, 2024 08:02
holkerveen pushed a commit to holkerveen/glsp-client that referenced this pull request Dec 21, 2024
holkerveen pushed a commit to holkerveen/glsp-client that referenced this pull request Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants