GLSP-1166 Fix dependency injection cycle in selection service #305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid binding of SelectionService as
IModelRootListner
. Instead directly inject theCommandStack
intoSelectionService
and manually register itself asIGModelRootListener
. This avoids a circular dependency injection if any of theSelectionListner
s wants to inject theActionDispatcher
.Can be tested e.g. by creating a
SelectionListener
that injects the action dispatcher:This fails on master with a circular dependency error but works with this change.
Fixes eclipse-glsp/glsp/issues/1166