Restore Projection bars #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
reviewed
Nov 6, 2023
There was a problem hiding this comment.
Looks good to me. Projection bars now work again as expected.
However, in the standalone example the styling is not ideal.
The scrollbar borders are hardly visible and maybe we could move the focus tracker UI Widget a little bit up so that it does not interfere with the projection bars.
|
@tortmayr Good point! I adapted the styling a bit so it looks better in the standalone case. If you have any particular suggestion, please let me know. |
martin-fleck-at
force-pushed
the
issues/1122
branch
from
14d678a to
8a20893
Compare
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
holkerveen
pushed a commit
to holkerveen/glsp-client
that referenced
this pull request
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates eclipse-glsp/glsp#1122