Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "workaround test results appearing in incorrect spot" #1031

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Revert "workaround test results appearing in incorrect spot" #1031

merged 1 commit into from
Jan 16, 2025

Conversation

jonahgraham
Copy link
Member

This reverts commit ae3aebc.

Part of #1002

@jonahgraham
Copy link
Member Author

The loss of the check_run functionality is worse than the side effect of it applied to the wrong place. We lose diffs on test runs and no where does main/branch test results get reported.

@jonahgraham jonahgraham merged commit 751b031 into eclipse-cdt:main Jan 16, 2025
3 of 4 checks passed
@jonahgraham jonahgraham deleted the revert branch January 16, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonahgraham