Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments from GitHub actions #1002

Open
2 tasks
jonahgraham opened this issue Jan 14, 2025 · 5 comments
Open
2 tasks

Add comments from GitHub actions #1002

jonahgraham opened this issue Jan 14, 2025 · 5 comments
Assignees
Labels
releng Release engineering and project management

Comments

@jonahgraham
Copy link
Member

Fix/cleanup auto-commenting in PRs from GitHub actions:

@jonahgraham jonahgraham added the releng Release engineering and project management label Jan 14, 2025
@jonahgraham jonahgraham self-assigned this Jan 14, 2025
@jonahgraham
Copy link
Member Author

tests are being reported against license checks,

image

this is related to OP and this also hides the problem of the license checks failing:

image

cc: @betamaxbandit

@jonahgraham
Copy link
Member Author

I was made aware of the license check fails because @betamaxbandit was getting emails about the fails, and I wasn't. I had turned off GitHub actions notifications in https://github.com/settings/notifications

image

jonahgraham added a commit to jonahgraham/cdt that referenced this issue Jan 15, 2025
When Eclipse Dash got moved to its own org, the path the shared
workflow needed to be updated. This commit does that

Part of eclipse-cdt#1002
@jonahgraham
Copy link
Member Author

For the JUnit comment doesn't always appear in the PR, there is a message in the build (link):

2025-01-15 17:59:29 +0000 - publish -  INFO - There is no pull request for commit 08d6339ba5fdd7b4b469f637d019bd8f65ca8f06

jonahgraham added a commit to jonahgraham/cdt that referenced this issue Jan 15, 2025
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Jan 15, 2025
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Jan 15, 2025
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Jan 15, 2025
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Jan 15, 2025
jonahgraham added a commit that referenced this issue Jan 15, 2025
When Eclipse Dash got moved to its own org, the path the shared
workflow needed to be updated. This commit does that

Part of #1002
@jonahgraham
Copy link
Member Author

this is related to OP and this also hides the problem of the license checks failing:

It doesn't actually hide it, the complete failure of the workflow seems to stop it being fully published to the PR, and then the JUnit results attaches itself randomly to a job, sometimes this one that was failing.

jonahgraham added a commit to jonahgraham/cdt that referenced this issue Jan 15, 2025
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Jan 16, 2025
jonahgraham added a commit that referenced this issue Jan 16, 2025
jonahgraham added a commit to jonahgraham/cdt that referenced this issue Jan 16, 2025
This helps it fit in the UI space GitHub gives it

Part of eclipse-cdt#1002
@jonahgraham
Copy link
Member Author

jonahgraham commented Jan 16, 2025

Originally posted by @github-actions[bot] in #1033 (comment)

Here are test results, but they say number of tests have gone down, which is weird. Some more investigation may be needed here. Actually these test results were accurate, some tests didn't run because of maven failed to complete build failure. See #1033 (comment)

Test Results

   590 files   -  11     590 suites   - 11   12m 59s ⏱️ +11s
10 079 tests  - 121  10 056 ✅  - 121  23 💤 ±0  0 ❌ ±0 
10 117 runs   - 121  10 094 ✅  - 121  23 💤 ±0  0 ❌ ±0 

Results for commit 4086e29. ± Comparison against base commit 751b031.

This pull request removes 121 tests.
org.eclipse.cdt.debug.core.memory.tests.PlainTextTransportTest ‑ transport0ffff
org.eclipse.cdt.debug.core.memory.tests.PlainTextTransportTest ‑ transport10000
org.eclipse.cdt.debug.core.memory.tests.PlainTextTransportTest ‑ transport10001
org.eclipse.cdt.debug.core.memory.tests.RAWBinaryTransportTest ‑ transport0ffff
org.eclipse.cdt.debug.core.memory.tests.RAWBinaryTransportTest ‑ transport10000
org.eclipse.cdt.debug.core.memory.tests.RAWBinaryTransportTest ‑ transport10001
org.eclipse.cdt.debug.core.memory.tests.SRecordTransportTest ‑ transport0ffff
org.eclipse.cdt.debug.core.memory.tests.SRecordTransportTest ‑ transport10000
org.eclipse.cdt.debug.core.memory.tests.SRecordTransportTest ‑ transport10001
org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui.test.PersistentSettingsManagerTest ‑ testGlobalParamsWithMultipleInstances
…

jonahgraham added a commit that referenced this issue Jan 16, 2025
This helps it fit in the UI space GitHub gives it

Part of #1002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releng Release engineering and project management
Projects
None yet
Development

No branches or pull requests

1 participant