standardize verbosity of ZenodoRecord methods #58
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @eblondel,
Thank you very much for developing this package! I was playing around with it and AFAIK it would seem that querying available versions for a DOI results in logging information being printed (regardless of the desired logging level). For example, please consider this reprex:
My understanding is that this issue is caused by a new
ZenodoManager
object being created in theZenodoRecord$getVersions()
method withlogger = "INFO"
). To resolve this, I suggest (per this PR) removing the logging information and using the defaultZenodoManager$new()
constructor. This change would be in line with otherZenodoRecord
methods that create newZenodoManager
objects (e.g. here, here, here). This issue is really minor in the grand scheme of things - I just thought it might be worth mentioning since the package in general provides excellent control over the desired logging level?How does that sound? Please let me know if I'm missing anything? I'm sorry if the documentation details a method for silently querying available versions, and I simply haven't read the documentation closely enough?
Session information