Some work on zen4R::download_zenodo() #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this commit, all md5sum checks happen after all files are downloaded (either sequential or parallel)
Having the option 'quiet' will make this more convenient for wrapping in other (external) functions, which will provide their own messages. If something goes wrong, warnings/errors are still printed.
Record ID and DOI are already in the initial message 'Will download x files ...'
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=========================================
- Coverage 5.93% 5.89% -0.04%
=========================================
Files 7 7
Lines 1079 1086 +7
=========================================
Hits 64 64
- Misses 1015 1022 +7
Continue to review full report at Codecov.
|
|
@florisvdh i've done a quick check, sounds ok for all your commits. Now in holidays, when back will do some further check and review your message on #35 before publishing on CRAN. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beside a few administrative fixes, some extra features and slightly improved [ZEN4R] messages are implemented.
The commit messages should explain most things (+ those with an asterisk have a message body).
This relates to #31, where more suggestions have been done about how [ZEN4R] messages may be further improved.
@eblondel feel free to discuss or change things that you would like to have changed.