Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we query MS Dynamics with odata, we need the enum name in the escaped value. Now we get:
https://mg-prod.operations.dynamics.com/data/Projects?$filter=ProjectStage eq ProjStatus.InProcess
but we need
https://mg-prod.operations.dynamics.com/data/Projects?$filter=ProjectStage eq Microsoft.Dynamics.DataEntities.ProjStatus'InProcess'
So in addition to this patch, when we reflect we also need to get the fully qualified name into the enum. Not:
Enum("ProjStatus", ...)
but:
Enum("Microsoft.Dynamics.DataEntities.ProjStatus", ...)
And I guess that
ProjectStage: str = EnumTypeProperty("ProjectStage", enum_class=ProjStatus)
should be
ProjectStage: Enum = EnumTypeProperty("ProjectStage", enum_class=ProjStatus)
?
If you don't have access to a system with enums, I can test changes if you need any.