Use Tempfile.open for automatic cleanup

dyarnell · Jul 17, 2013 · 656d800 · 656d800
1 parent 3ada8f4
commit 656d800
Showing 1 changed file with 1 addition and 6 deletions.
diff --git a/app/models/key.rb b/app/models/key.rb
@@ -56,15 +56,10 @@ def shell_id
   def generate_fingerpint
     cmd_status = 0
     cmd_output = ''
-    file = Tempfile.new('gitlab_key_file')
-
-    begin
+    Tempfile.open('gitlab_key_file') do |file|
       file.puts key
       file.rewind
       cmd_output, cmd_status = popen("ssh-keygen -lf #{file.path}", '/tmp')
-    ensure
-      file.close
-      file.unlink # deletes the temp file
     end
 
     if cmd_status.zero?