Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .NET Framework to 4.8 #406

Closed
wants to merge 1 commit into from

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Jun 7, 2024

Simpler version of #404 to test if the failing workflow has anything to do with the change to the sdk format. If this passes without a hitch, then I'll have to revisit the sdk version and see what can be fixed there. If this also fails, there's likely something wrong with the workflow itself.

Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 11.79%. Comparing base (fb33acd) to head (1bd270e).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #406   +/-   ##
=======================================
  Coverage   11.79%   11.79%           
=======================================
  Files          89       89           
  Lines        3061     3061           
  Branches      388      388           
=======================================
  Hits          361      361           
  Misses       2681     2681           
  Partials       19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Repiteo
Copy link
Contributor Author

Repiteo commented Jun 13, 2024

Got the sdk version working; closing

@Repiteo Repiteo closed this Jun 13, 2024
@Repiteo Repiteo deleted the modernize-frameworks-simple branch June 13, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant