Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a clang-format GitHub action #82

Merged
merged 1 commit into from
Aug 2, 2024
Merged

Add a clang-format GitHub action #82

merged 1 commit into from
Aug 2, 2024

Conversation

JelteF
Copy link
Collaborator

@JelteF JelteF commented Aug 1, 2024

I had a few times that clang-format would change code that I did not
touch. This adds a GitHub action that checks if the code in a PR is
correctly formatted.

@Tishj
Copy link
Collaborator

Tishj commented Aug 1, 2024

If we're adding this, can we please add a format recipe to the Makefile so we can format code according to these rules?

@JelteF JelteF force-pushed the clang-format branch 8 times, most recently from 564a104 to e7ea670 Compare August 1, 2024 14:09
I had a few times that clang-format would change code that I did not
touch. This adds a github action that checks if the code in a PR is
correctly formatted.
@JelteF JelteF force-pushed the clang-format branch 2 times, most recently from 6e39829 to 696ad83 Compare August 1, 2024 14:21
@JelteF
Copy link
Collaborator Author

JelteF commented Aug 1, 2024

can we please add a format recipe to the Makefile so we can format code according to these rules?

Done

@wuputah wuputah requested review from mkaruza and Tishj August 1, 2024 15:34
@JelteF JelteF merged commit 46e3ba4 into main Aug 2, 2024
2 checks passed
@JelteF JelteF deleted the clang-format branch August 2, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants