Use cloud secret from quack.secret table
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wuputah
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
My only complaint / request is to name it quack.secrets instead, though this is just the convention I am used to, I know some people have the convention to use singular rather than plural table names.
also this closes #49 since this adds endpoint support. 👍
* There can be multiple cloud secrets provided. Secrets can be added to `quack.secrets` table. All secrets in table will be added to duckdb execution.
|
Update with name changed to |
|
Awesome, nice work! |
wuputah
approved these changes
Jun 20, 2024
Tishj
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quack.secrettable. All secrets in table will be added to duckdb execution.closes #49
closes #50
closes #51