Regression test for MATERIALIZED VIEWs #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mkaruza
commented
Jun 18, 2024
mkaruza
commented
- Utility statement can do query planning. Skip Quack execution if it is starting as utility statement.
Tishj
reviewed
Jun 19, 2024
src/quack_hooks.cpp
Outdated
| @@ -75,11 +76,13 @@ quack_utility(PlannedStmt *pstmt, const char *queryString, bool readOnlyTree, Pr | |||
| } | |||
| } | |||
|
|
|||
| isUtilityStatement = true; | |||
There was a problem hiding this comment.
I'm not sure I follow what's happening
We set isUtilityStatement to true when we come from quack_utility, presumably PrevProcessUtilityHook ends up calling quack_planner ?
Can't we deduce from the Query that it's a utility statement?
If somewhere along the line the planner fails and we don't get back to isUtilityStatement = false we can get into a weird and hard to debug situation, no?
There was a problem hiding this comment.
@Tishj you are right, it is problematic. Pushed changes so we will check ActivePortal global variable for execution
mkaruza
force-pushed
the
materialized-view
branch
2 times, most recently
from
ca8d0b7 to
775f474
Compare
* Utility statement can do query planning. Skip Quack execution if it is starting as utility statement.
mkaruza
force-pushed
the
materialized-view
branch
from
775f474 to
8d823d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.