Array error crash fix #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
elog(ERROR, ...)inside DuckDB worker threads, this appears to cause a crash when two or more threads run into an error in parallel.Another attempt was made to synchronize the
elogcalls, but even with that the crash was still present.I assume the elog(ERROR, ..) invalidates some internal state and does not expect to be called more than once.
By throwing DuckDB exceptions, we instead throw the
elog(ERROR, ..)from the main thread whenresult->HasError()is true, indicating that one or more worker threads stumbled upon an error.