Add support for scanning views #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m it, which then gets bound, causing us to do another replacement scan on the table referenced by the view
…The only thing we're missing is the alias that was attached to the RangeTblEntry but since we are parsing the same query as Postgres, the alias should be resolved by the system anyways
…st use this for now
|
@mkaruza any requests for tests, things that might require extra attention, pitfalls I haven't foreseen? |
mkaruza
requested changes
Jun 13, 2024
|
@Tishj i left comments that i would need further discussion. Other i will try this today/tomorrow and provide you feedback if anything else is missing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First we took the
parse->rtablethat Postgres has provided to us after parsing the query, then we looked through this list in the replacement scan, we returned this RangeTblEntry and used it for the Oid throughout execution of the scan.The only benefit that the RangeTblEntry gave us was that it contained an alias for where it appeared in the query, but we don't need that, DuckDB already provides us the alias.
Internal details:
Inside the replacement scan we find the Oid given the name (schema+table), from there we check if this is a VIEW or not.
If it is, we look up the views definition and return a SubqueryRef that will get bound later, essentially rewriting:
select * from vwintoselect * from (select * from tbl)