Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match heap tables with fully qualified name #33

Merged
merged 1 commit into from
May 27, 2024
Merged

Match heap tables with fully qualified name #33

merged 1 commit into from
May 27, 2024

Conversation

mkaruza
Copy link
Collaborator

@mkaruza mkaruza commented May 24, 2024

  • Matching tables entry in replacement scan should work with a fully qualified name.
  • Alias for TableRef is set explicitly

@mkaruza mkaruza requested a review from Tishj May 24, 2024 09:04
@mkaruza mkaruza force-pushed the search_path branch 2 times, most recently from ecc3704 to 2f279fb Compare May 24, 2024 09:08
@mkaruza
Copy link
Collaborator Author

mkaruza commented May 24, 2024

For some reason, test is failing here - it was fine when u tried it locally. @wuputah can you fetch diff file what is wrong.

@wuputah
Copy link
Collaborator

wuputah commented May 24, 2024

The diff is currently printed as part of the action.
https://github.com/hydradatabase/pg_quack_internal/actions/runs/9221511930/job/25370733251#step:7:1

* Matching tables entry in replacement scan should work with a fully qualified
  name.
* Alias for `TableRef` is set explicitly
Base automatically changed from copy-to to main May 27, 2024 08:05
@mkaruza mkaruza merged commit 47a6105 into main May 27, 2024
2 checks passed
@mkaruza mkaruza deleted the search_path branch May 27, 2024 08:05
@wuputah wuputah added this to the 0.1.0 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants