COPY .. TO functionality #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there a way we can add tests to this? it would need creds, which is tricky. |
|
For our own tests we use Minio to host a server locally (in the CI) we can connect to |
Tishj
reviewed
May 22, 2024
| context.transaction.Commit(); | ||
|
|
||
| if (strlen(quack_secret) != 0) { | ||
| std::vector<std::string> quackSecret = quack::tokenizeString(quack_secret, '#'); |
There was a problem hiding this comment.
are we in control of this string?
I noticed the length is never checked or asserted, but we blindly access [1], [2], [3] (0 is ignored?)
There was a problem hiding this comment.
This PR is still in progress but i leave comment that will apply in future. Yes we control this variable, once the user sets this with SET quack.cloud_secret to '...' function quack_cloud_secret_check_hooks is responsible for initial checking. So if this is successful we know that there are all required parameters
Tishj
reviewed
May 22, 2024
* Now we are intercepting utility that will handle COPY utility. COPY through DuckDB will only be executed if COPY destination starts with 's3://' i.e. to S3 bucket. User first needs to setup valid `quack.cloud_secret`. Both COPY from table or specified query works.
wuputah
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quack.cloud_secret. Both COPY from table or specified query works.