Column selection / Filtering / Projections #15
Conversation
mkaruza
force-pushed
the
projections-selection
branch
from
3dab29d to
111f266
Compare
src/quack_types.cpp
Outdated
| auto &array_mask = duckdb::FlatVector::Validity(result); | ||
| array_mask.SetInvalid(offset); | ||
| } else { | ||
| Datum value = projections.empty() ? values[i] : values[projections[i]]; |
There was a problem hiding this comment.
Can we add tests for the pushdown?
There was a problem hiding this comment.
Both to verify that the change is working, but more so to serve as a regression test for any future changes
* Read columns that are needed for query * Skip query if any table is from PG_CATALOG_NAMESPACE or PG_TOAST_NAMESPACE * Thread safe detoasting
mkaruza
force-pushed
the
projections-selection
branch
from
111f266 to
24c6c40
Compare
|
I feel like the last commit should be a separate PR after this one is finished, don't you agree? |
mkaruza
changed the title
|
Yeah, i agree but this is one big pile of features right now (probably a lot of testing and experimentation) |
|
Need also testing part, but that will be added soon |
* Filter tuple on page level
mkaruza
force-pushed
the
projections-selection
branch
from
6a92567 to
28e46d3
Compare
* COUNT(*) doesn't require any columns to be retrieved so we only count tuples that pass visibility without fetching.
* Fixed incorrect column id for query filtering * Writing output vector now works with/without projection information
| struct varlena *result; | ||
| int32 rawsize; | ||
|
|
||
| result = (struct varlena *)duckdb_malloc(VARDATA_COMPRESSED_GET_EXTSIZE(value) + VARHDRSZ); |
There was a problem hiding this comment.
duckdb_malloc/free are just wrappers around malloc and free, they don't serve an added benefit
Also these methods are part of the C api, which we're not using here
void *duckdb_malloc(size_t size) {
return malloc(size);
}
void duckdb_free(void *ptr) {
free(ptr);
}
| @@ -162,6 +185,24 @@ PostgresHeapSeqScan::ParallelScanState::AssignNextBlockNumber() { | |||
| return block_number; | |||
| } | |||
|
|
|||
| void | |||
| PostgresHeapSeqParallelScanState::PrefetchNextRelationPages(Relation rel) { | |||
There was a problem hiding this comment.
Yes, unused - but if this is not something that will be needed will be removed before public release.
closes #11