Improve payout flow #1851
Open
Improve payout flow #1851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Removed date formatting from the charge-succeeded webhook, directly using the payout period dates. - Introduced a new email template for partner payout confirmation. - Updated the partner payout sent email template to use Date objects for start and end dates, enhancing date handling. - Modified the confirm payouts action to send confirmation emails to partners when payouts are processed via ACH, including relevant payout details. - Cleaned up unused code in the payout invoice sheet component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to the payout processing and email notification system. The most important changes include updating the payout confirmation process to support different payment methods, modifying email templates to dynamically format payout dates, and enhancing the UI for selecting payment methods.
Payout Processing Updates:
apps/web/lib/actions/partners/confirm-payouts.ts: Added support for different payment methods (ACH and card) and included validation for the selected payment method. The payout fee is now determined based on the payment method. [1] [2] [3] [4]apps/web/lib/partners/constants.ts: Introduced separate constants for ACH and card payout fees.Email Template Modifications:
apps/web/emails/partner-payout-confirmed.tsx: Created a new email template for confirming partner payouts with dynamic date formatting.apps/web/emails/partner-payout-sent.tsx: Updated the existing email template to dynamically format payout dates and include the correct payment method details. [1] [2] [3] [4] [5]UI Enhancements:
apps/web/ui/partners/payout-invoice-sheet.tsx: Enhanced the UI to allow users to select a payment method when confirming payouts. Added tooltips to display payment method details and fees. [1] [2]Code Cleanup:
apps/web/app/api/stripe/webhook/charge-succeeded.ts: Removed unused importformatDateand updated the code to use raw date values forstartDateandendDate. [1] [2]These changes collectively improve the flexibility and user experience of the payout processing system.