Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: EOL'd github actions: upgrade all that are possible to upgrade #1400

Merged
merged 7 commits into from
Dec 5, 2024
Merged

fix: EOL'd github actions: upgrade all that are possible to upgrade #1400

merged 7 commits into from
Dec 5, 2024

Conversation

jzacsh
Copy link
Collaborator

@jzacsh jzacsh commented Dec 5, 2024 

$ find .github/ -type f -exec \
  sed -Ei 's,actions?\/(.*)\@v[[:digit:]],actions/\1\@v3,g' {} \;

unsure if any action names changed (so unsure this will work), but guessing ci/cd will tell us.

part part of #1397

jzacsh added 7 commits December 5, 2024 00:18
@jzacsh
fix: search/replace all action refs v{1,2} -> v3
08399eb 
```sh
$ find .github/ -type f -exec \
  sed -Ei 's,actions?\/(.*)\@v[[:digit:]],actions/\1\@V3,g' {} \;
```

unsure if any action names changed (so unsure this will work), but
guessing ci/cd will tell us.
@jzacsh
upgrade straight to v4: workaround weird v3 bug?
e080b75
@jzacsh
fix: github repo for actions is only at v2
f7585cf
@jzacsh
trying v2 on init only per docs[1]
b4cd757 
[1]: https://docs.github.com/en/code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning#changing-the-languages-that-are-analyzed
@jzacsh
more v3 per https://github.blog/changelog/2024-01-12-code-scanning-de…
f748d47 
…precation-of-codeql-action-v2/
@jzacsh
repo typo? not plural
27970fd
@jzacsh
correct CI/CD name so scanning for the rightoutput is less confusing
fda9c0e
@jzacsh jzacsh changed the title fix: github actions: search/replac refs v{1,2} -> v3 fix: github actions: upgrade all that are possible to upgrade Dec 5, 2024
@jzacsh jzacsh changed the title fix: github actions: upgrade all that are possible to upgrade fix: EOL'd github actions: upgrade all that are possible to upgrade Dec 5, 2024
@jzacsh jzacsh marked this pull request as ready for review December 5, 2024 17:03
@jzacsh jzacsh requested a review from seehamrun December 5, 2024 17:03
@seehamrun
Copy link
Collaborator

Also related: #1022

@jzacsh jzacsh merged commit be94249 into dtinit:master Dec 5, 2024
5 checks passed
@jzacsh jzacsh deleted the eol-fix-githubcodeql branch December 5, 2024 18:08
@jzacsh jzacsh mentioned this pull request Dec 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seehamrun seehamrun seehamrun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jzacsh @seehamrun