Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend OptionSource to use extractDataByPath() #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Extend OptionSource to use extractDataByPath() #171

wants to merge 1 commit into from

Conversation

Keelan
Copy link

@Keelan Keelan commented Apr 11, 2021

Extend displayPath and valuePath to traverse the object using extractDataByPath function

@Keelan
Extend OptionSource to use extractDataByPath()
8dd4b54 
Extend `displayPath` and `valuePath` to traverse the object using `extractDataByPath` function
@Keelan Keelan mentioned this pull request Apr 11, 2021
Open
@Keelan
Copy link
Author

Keelan commented Apr 12, 2021

#169

dsternlicht
dsternlicht requested changes Apr 12, 2021
View reviewed changes
Copy link
Owner

@dsternlicht dsternlicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. One thing thought, you're throwing an exception, who should catch it? You don't want to break the app because of it 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsternlicht dsternlicht dsternlicht requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Keelan @dsternlicht