Adding support of queryParams on paramsHeaders and URL #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ueryParams in url
# New "feature"
Updating the value of your queryParameters can know affect your url and your header.
## How to use
Juste had :{querryParametersName} to your path and/or your header !
## Exemple
You are the owner of an API that manage different club.\
You want to list every user of a club, nothing more simple :
```
"url": "http://my_beautiful_path/api/club/:club_id/",
[...]
"queryParams": [
{
"name": "club_id",
"type": "select",
"label": "Club",
"optionSource": {
"url": "http://my_beautiful_path/api/clubs/",
"displayPath": "name",
"dataPath": null,
"valuePath": "id"
},
"required": true
}
]
```
dsternlicht
requested changes
Apr 5, 2020
| // TODO: Add docs to "urlReplaceOnly" | ||
| if (param.urlReplaceOnly) { | ||
| const urlParamName = `:${param.name}`; | ||
| outputUrl = outputUrl.replace(urlParamName, param.value as string); | ||
| } else { | ||
| params.push(`${param.name}=${param.value || ''}`); | ||
| if (url.includes(":"+param.name)) |
There was a problem hiding this comment.
Please add curly brackets to if/else statements.
| @@ -61,12 +61,22 @@ class HttpService { | |||
| continue; | |||
| } | |||
|
|
|||
| //eslint-disable-next-line | |||
| Object.entries(headers).map(([key, value]) => { | |||
There was a problem hiding this comment.
I'm not sure it's the current place to add this logic. buildUrl meant (as the name suggests), to build the request url.
To manipulate headers, please add another method,
| // TODO: Add docs to "urlReplaceOnly" | ||
| if (param.urlReplaceOnly) { | ||
| const urlParamName = `:${param.name}`; | ||
| outputUrl = outputUrl.replace(urlParamName, param.value as string); | ||
| } else { | ||
| params.push(`${param.name}=${param.value || ''}`); | ||
| if (url.includes(":"+param.name)) |
There was a problem hiding this comment.
Please use string concatenation.
| // TODO: Add docs to "urlReplaceOnly" | ||
| if (param.urlReplaceOnly) { | ||
| const urlParamName = `:${param.name}`; | ||
| outputUrl = outputUrl.replace(urlParamName, param.value as string); | ||
| } else { | ||
| params.push(`${param.name}=${param.value || ''}`); | ||
| if (url.includes(":"+param.name)) |
There was a problem hiding this comment.
Please use string concatenation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New "feature"
Updating the value of your queryParameters can know affect your url and your header.
How to use
Juste had :{queryParametersName} to your path and/or your header !
Exemple
You are the owner of an API that manage different club.
You want to list every user of a club, nothing more simple :